diff options
| author | Mickaël Salaün <mic@digikod.net> | 2024-05-11 19:14:37 +0200 |
|---|---|---|
| committer | Mickaël Salaün <mic@digikod.net> | 2024-05-11 19:18:42 +0200 |
| commit | 7e4042abe2ee7c0977fd8bb049a6991b174a5e6f (patch) | |
| tree | cc9ef85764140fd4a51f22565e46b37ccee9b9a9 /tools | |
| parent | 37dc2e0d38d6eb690ee043b43ee6f7cdf2994bf6 (diff) | |
| download | lwn-7e4042abe2ee7c0977fd8bb049a6991b174a5e6f.tar.gz lwn-7e4042abe2ee7c0977fd8bb049a6991b174a5e6f.zip | |
selftests/landlock: Fix FS tests when run on a private mount point
According to the test environment, the mount point of the test's working
directory may be shared or not, which changes the visibility of the
nested "tmp" mount point for the test's parent process calling
umount("tmp").
This was spotted while running tests in containers [1], where mount
points are private.
Cc: Günther Noack <gnoack@google.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Link: https://github.com/landlock-lsm/landlock-test-tools/pull/4 [1]
Fixes: 41cca0542d7c ("selftests/harness: Fix TEST_F()'s vfork handling")
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20240511171445.904356-3-mic@digikod.net
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/testing/selftests/landlock/fs_test.c | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/tools/testing/selftests/landlock/fs_test.c b/tools/testing/selftests/landlock/fs_test.c index 9a6036fbf289..46b9effd53e4 100644 --- a/tools/testing/selftests/landlock/fs_test.c +++ b/tools/testing/selftests/landlock/fs_test.c @@ -293,7 +293,15 @@ static void prepare_layout(struct __test_metadata *const _metadata) static void cleanup_layout(struct __test_metadata *const _metadata) { set_cap(_metadata, CAP_SYS_ADMIN); - EXPECT_EQ(0, umount(TMP_DIR)); + if (umount(TMP_DIR)) { + /* + * According to the test environment, the mount point of the + * current directory may be shared or not, which changes the + * visibility of the nested TMP_DIR mount point for the test's + * parent process doing this cleanup. + */ + ASSERT_EQ(EINVAL, errno); + } clear_cap(_metadata, CAP_SYS_ADMIN); EXPECT_EQ(0, remove_path(TMP_DIR)); } |