diff options
| author | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-20 12:50:29 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2011-05-20 12:50:29 -0700 |
| commit | 268bb0ce3e87872cb9290c322b0d35bce230d88f (patch) | |
| tree | c8331ade4a3e24fc589c4eb62731bc2312d35333 /tools | |
| parent | 257313b2a87795e07a0bdf58d0fffbdba8b31051 (diff) | |
| download | lwn-268bb0ce3e87872cb9290c322b0d35bce230d88f.tar.gz lwn-268bb0ce3e87872cb9290c322b0d35bce230d88f.zip | |
sanitize <linux/prefetch.h> usage
Commit e66eed651fd1 ("list: remove prefetching from regular list
iterators") removed the include of prefetch.h from list.h, which
uncovered several cases that had apparently relied on that rather
obscure header file dependency.
So this fixes things up a bit, using
grep -L linux/prefetch.h $(git grep -l '[^a-z_]prefetchw*(' -- '*.[ch]')
grep -L 'prefetchw*(' $(git grep -l 'linux/prefetch.h' -- '*.[ch]')
to guide us in finding files that either need <linux/prefetch.h>
inclusion, or have it despite not needing it.
There are more of them around (mostly network drivers), but this gets
many core ones.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/include/linux/list.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/perf/util/include/linux/list.h b/tools/perf/util/include/linux/list.h index 356c7e467b83..99358d61e9a5 100644 --- a/tools/perf/util/include/linux/list.h +++ b/tools/perf/util/include/linux/list.h @@ -23,5 +23,5 @@ static inline void list_del_range(struct list_head *begin, * @head: the head for your list. */ #define list_for_each_from(pos, head) \ - for (; prefetch(pos->next), pos != (head); pos = pos->next) + for (; pos != (head); pos = pos->next) #endif |