diff options
| author | Ido Schimmel <idosch@mellanox.com> | 2018-12-20 19:42:35 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-12-20 15:48:54 -0800 |
| commit | 29b1e34efd39ee9f6bc2db3fafad0e4615f15475 (patch) | |
| tree | ce1f28116d763eb2d27655c1102770ea390566e6 /tools | |
| parent | d8a1f7ab2c1fb4ee53c16ad048ad045770d99f14 (diff) | |
| download | lwn-29b1e34efd39ee9f6bc2db3fafad0e4615f15475.tar.gz lwn-29b1e34efd39ee9f6bc2db3fafad0e4615f15475.zip | |
selftests: mlxsw: Adjust test regarding VID 1
Previous patches made it possible to create VLAN devices with VID 1 over
mlxsw ports. Adjust the test to verify such an operation succeeds.
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reviewed-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools')
| -rwxr-xr-x | tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh | 13 |
1 files changed, 8 insertions, 5 deletions
diff --git a/tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh b/tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh index 9040bfbddfba..94fdbf215c14 100755 --- a/tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh +++ b/tools/testing/selftests/drivers/net/mlxsw/rtnetlink.sh @@ -255,15 +255,18 @@ bridge_vlan_flags_test() vlan_1_test() { - # Test that VLAN 1 cannot be configured, as it is used internally for - # untagged traffic. See commit 47bf9df2e820 ("mlxsw: spectrum: Forbid - # creation of VLAN 1 over port/LAG") for more details + # Test that VLAN 1 can be configured over mlxsw ports. In the past it + # was used internally for untagged traffic. See commit 47bf9df2e820 + # ("mlxsw: spectrum: Forbid creation of VLAN 1 over port/LAG") for more + # details RET=0 - ip link add link $swp1 name $swp1.1 type vlan id 1 &> /dev/null - check_fail $? "managed to create vlan 1 when should not" + ip link add link $swp1 name $swp1.1 type vlan id 1 + check_err $? "did not manage to create vlan 1 when should" log_test "vlan 1" + + ip link del dev $swp1.1 } lag_bridge_upper_test() |