diff options
author | Steven Rostedt (Red Hat) <rostedt@goodmis.org> | 2014-10-22 10:11:47 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-01-16 06:59:46 -0800 |
commit | a7c3ff297f15acba8ad98cf6cbaf32199e012521 (patch) | |
tree | bbe5ef5fa127985054acdaf5f467b3fa810177b7 /tools | |
parent | 3b4a99e9a2e01b87a9dc8a37531a2b656e174ffb (diff) | |
download | lwn-a7c3ff297f15acba8ad98cf6cbaf32199e012521.tar.gz lwn-a7c3ff297f15acba8ad98cf6cbaf32199e012521.zip |
ktest: Fix make_min_config to handle new assign_configs call
commit 9972fc0b859e7aaeb6d2d33bdb591959d9a436c0 upstream.
Commit 6071c22e1755 "ktest: Rewrite the config-bisect to actually work"
fixed the config-bisect to work nicely but in doing so it broke
make_min_config by changing the way assign_configs works.
The assign_configs function now adds the config to the hash even if
it is disabled, but changes the hash value to be that of the
line "# CONFIG_FOO is not set". Unfortunately, the make_min_config
test only checks to see if the config is removed. It now needs to
check if the config is in the hash and not set to be disabled.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools')
-rwxr-xr-x | tools/testing/ktest/ktest.pl | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index bf1398180785..dcb1e9ac949c 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -3571,7 +3571,9 @@ sub test_this_config { undef %configs; assign_configs \%configs, $output_config; - return $config if (!defined($configs{$config})); + if (!defined($configs{$config}) || $configs{$config} =~ /^#/) { + return $config; + } doprint "disabling config $config did not change .config\n"; |