diff options
| author | Lucas Stach <l.stach@pengutronix.de> | 2016-01-25 16:50:02 -0600 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2016-05-01 00:05:44 +0200 |
| commit | 92d27c4aaca0d15bb742de785dfd57f0f68aa586 (patch) | |
| tree | 362e66b7afda45a82344b1221b9cdbe510fed59a /tools | |
| parent | f5aa19a43aaba8be755936fa2dbe93404fcec169 (diff) | |
| download | lwn-92d27c4aaca0d15bb742de785dfd57f0f68aa586.tar.gz lwn-92d27c4aaca0d15bb742de785dfd57f0f68aa586.zip | |
PCI: imx6: Move link up check into imx6_pcie_wait_for_link()
commit 4d107d3b5a686b5834e533a00b73bf7b1cf59df7 upstream.
imx6_pcie_link_up() previously used usleep_range() to wait for the link to
come up. Since it may be called while holding the config spinlock, the
sleep causes a "BUG: scheduling while atomic" error.
Instead of waiting for the link to come up in imx6_pcie_link_up(), do the
waiting in imx6_pcie_wait_for_link(), where we're not holding a lock and
sleeping is allowed.
[bhelgaas: changelog, references to bugzilla and f95d3ae77191]
Link: https://bugzilla.kernel.org/show_bug.cgi?id=100031
Fixes: f95d3ae77191 ("PCI: imx6: Wait for retraining")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
[bwh: Backported to 3.16: also update the retry loop in
imx6_pcie_wait_for_link() as done upstream in commit 6cbb247e85eb
("PCI: designware: Wait for link to come up with consistent style")]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'tools')
0 files changed, 0 insertions, 0 deletions