diff options
| author | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-08-10 16:53:54 -0300 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2015-09-30 13:20:39 +0100 |
| commit | 8bfd9fe5c2903f1064cc8e1e77f7ca93ea758998 (patch) | |
| tree | 481bd73bc9b9d8cc26b938ecaf437e0dd51b19f6 /tools | |
| parent | a5fda5d5853bbe8a3ada1d413b2b640e95d90c8d (diff) | |
| download | lwn-8bfd9fe5c2903f1064cc8e1e77f7ca93ea758998.tar.gz lwn-8bfd9fe5c2903f1064cc8e1e77f7ca93ea758998.zip | |
perf hists: Update the column width for the "srcline" sort key
commit e8e6d37e73e6b950c891c780745460b87f4755b6 upstream.
When we introduce a new sort key, we need to update the
hists__calc_col_len() function accordingly, otherwise the width
will be limited to strlen(header).
We can't update it when obtaining a line value for a column (for
instance, in sort__srcline_cmp()), because we reset it all when doing a
resort (see hists__output_recalc_col_len()), so we need to, from what is
in the hist_entry fields, set each of the column widths.
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Fixes: 409a8be61560 ("perf tools: Add sort by src line/number")
Link: http://lkml.kernel.org/n/tip-jgbe0yx8v1gs89cslr93pvz2@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/perf/util/hist.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 30df6187ee02..e2a462bf5822 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -156,6 +156,9 @@ void hists__calc_col_len(struct hists *hists, struct hist_entry *h) hists__new_col_len(hists, HISTC_LOCAL_WEIGHT, 12); hists__new_col_len(hists, HISTC_GLOBAL_WEIGHT, 12); + if (h->srcline) + hists__new_col_len(hists, HISTC_SRCLINE, strlen(h->srcline)); + if (h->transaction) hists__new_col_len(hists, HISTC_TRANSACTION, hist_entry__transaction_len()); |