diff options
author | Zongmin Zhou <zhouzongmin@kylinos.cn> | 2024-10-24 10:27:00 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2024-10-29 04:23:23 +0100 |
commit | e7cd4b811c9e019f5acbce85699c622b30194c24 (patch) | |
tree | fd2ba1498687625833778f14e7aa0eb69ac04c23 /tools | |
parent | 5963e0786a3f28cd87c950dec18574bfcceb8335 (diff) | |
download | lwn-e7cd4b811c9e019f5acbce85699c622b30194c24.tar.gz lwn-e7cd4b811c9e019f5acbce85699c622b30194c24.zip |
usbip: tools: Fix detach_port() invalid port error path
The detach_port() doesn't return error
when detach is attempted on an invalid port.
Fixes: 40ecdeb1a187 ("usbip: usbip_detach: fix to check for invalid ports")
Cc: stable@vger.kernel.org
Reviewed-by: Hongren Zheng <i@zenithal.me>
Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Zongmin Zhou <zhouzongmin@kylinos.cn>
Link: https://lore.kernel.org/r/20241024022700.1236660-1-min_halo@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools')
-rw-r--r-- | tools/usb/usbip/src/usbip_detach.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index b29101986b5a..6b78d4a81e95 100644 --- a/tools/usb/usbip/src/usbip_detach.c +++ b/tools/usb/usbip/src/usbip_detach.c @@ -68,6 +68,7 @@ static int detach_port(char *port) } if (!found) { + ret = -1; err("Invalid port %s > maxports %d", port, vhci_driver->nports); goto call_driver_close; |