diff options
| author | Eric Curtin <ericcurtin17@gmail.com> | 2015-09-15 21:27:20 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-09-22 12:07:45 -0700 |
| commit | 0c61814544cfe0db7c4c4adf38e51d015c7175f9 (patch) | |
| tree | c068c4a8d6ff0e6590f090b373b496e35532f8d8 /tools/usb | |
| parent | 1f93e4a96c9109378204c147b3eec0d0e8100fde (diff) | |
| download | lwn-0c61814544cfe0db7c4c4adf38e51d015c7175f9.tar.gz lwn-0c61814544cfe0db7c4c4adf38e51d015c7175f9.zip | |
tools: usbip: detach: avoid calling strlen() at each iteration
Instead of calling strlen on every iteration of the for loop, just call it
once and cache the result in a temporary local variable which will be used
in the for loop instead.
Signed-off-by: Eric Curtin <ericcurtin17@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'tools/usb')
| -rw-r--r-- | tools/usb/usbip/src/usbip_detach.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/usb/usbip/src/usbip_detach.c b/tools/usb/usbip/src/usbip_detach.c index 05c6d15856eb..9db9d21bb2ec 100644 --- a/tools/usb/usbip/src/usbip_detach.c +++ b/tools/usb/usbip/src/usbip_detach.c @@ -47,7 +47,9 @@ static int detach_port(char *port) uint8_t portnum; char path[PATH_MAX+1]; - for (unsigned int i = 0; i < strlen(port); i++) + unsigned int port_len = strlen(port); + + for (unsigned int i = 0; i < port_len; i++) if (!isdigit(port[i])) { err("invalid port %s", port); return -1; |