diff options
| author | Russ Dill <Russ.Dill@ti.com> | 2012-04-23 19:43:00 -0700 |
|---|---|---|
| committer | Steven Rostedt <rostedt@goodmis.org> | 2012-05-01 08:25:44 -0400 |
| commit | 5158ba3ea7fc8c3deafec769a32bc6eb869c3608 (patch) | |
| tree | 8fbf9f20e08c536fbf314f55f00fe4903d048a39 /tools/testing/ktest | |
| parent | 66f75a5d028beaf67c931435fdc3e7823125730c (diff) | |
| download | lwn-5158ba3ea7fc8c3deafec769a32bc6eb869c3608.tar.gz lwn-5158ba3ea7fc8c3deafec769a32bc6eb869c3608.zip | |
ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP
When BISECT_REVERSE and BISECT_SKIP are used together with boot or test
testing, build failures are treated as boot or test failures and
'git bisect bad' is executed instead of 'git bisect skip'. This is because
the $ret value of -1 is treated as a build failure, but the $reverse_bisect
logic does not properly handle this.
Simple fix, only invert it if it is positive.
Link: http://lkml.kernel.org/r/1335235380-8509-1-git-send-email-Russ.Dill@ti.com
Signed-off-by: Russ Dill <Russ.Dill@ti.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'tools/testing/ktest')
| -rwxr-xr-x | tools/testing/ktest/ktest.pl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl index 95d6a6f7c33a..d2ede59b9a3c 100755 --- a/tools/testing/ktest/ktest.pl +++ b/tools/testing/ktest/ktest.pl @@ -2192,7 +2192,7 @@ sub run_bisect { } # Are we looking for where it worked, not failed? - if ($reverse_bisect) { + if ($reverse_bisect && $ret >= 0) { $ret = !$ret; } |