diff options
| author | Josh Poimboeuf <jpoimboe@redhat.com> | 2021-06-23 10:42:28 -0500 |
|---|---|---|
| committer | Ingo Molnar <mingo@kernel.org> | 2021-06-24 08:55:20 +0200 |
| commit | e31694e0a7a709293319475d8001e05e31f2178c (patch) | |
| tree | f35beede10fd6162f6e010d6e2053109c9390ad0 /tools/objtool | |
| parent | 49faa77759b211fff344898edc23bb780707fff5 (diff) | |
| download | lwn-e31694e0a7a709293319475d8001e05e31f2178c.tar.gz lwn-e31694e0a7a709293319475d8001e05e31f2178c.zip | |
objtool: Don't make .altinstructions writable
When objtool creates the .altinstructions section, it sets the SHF_WRITE
flag to make the section writable -- unless the section had already been
previously created by the kernel. The mismatch between kernel-created
and objtool-created section flags can cause failures with external
tooling (kpatch-build). And the section doesn't need to be writable
anyway.
Make the section flags consistent with the kernel's.
Fixes: 9bc0bb50727c ("objtool/x86: Rewrite retpoline thunk calls")
Reported-by: Joe Lawrence <joe.lawrence@redhat.com>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/6c284ae89717889ea136f9f0064d914cd8329d31.1624462939.git.jpoimboe@redhat.com
Diffstat (limited to 'tools/objtool')
| -rw-r--r-- | tools/objtool/arch/x86/decode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/objtool/arch/x86/decode.c b/tools/objtool/arch/x86/decode.c index 523aa4157f80..bc821056aba9 100644 --- a/tools/objtool/arch/x86/decode.c +++ b/tools/objtool/arch/x86/decode.c @@ -684,7 +684,7 @@ static int elf_add_alternative(struct elf *elf, sec = find_section_by_name(elf, ".altinstructions"); if (!sec) { sec = elf_create_section(elf, ".altinstructions", - SHF_WRITE, size, 0); + SHF_ALLOC, size, 0); if (!sec) { WARN_ELF("elf_create_section"); |