diff options
| author | Takashi Iwai <tiwai@suse.de> | 2020-04-20 09:55:29 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2020-04-21 08:00:41 +0200 |
| commit | 7686e3485253635c529cdd5f416fc640abaf076f (patch) | |
| tree | d85bab8e433de3e7f18b34ec34e63b326265f67a /sound | |
| parent | 6f4ea2074ddf689ac6f892afa58515032dabf2e4 (diff) | |
| download | lwn-7686e3485253635c529cdd5f416fc640abaf076f.tar.gz lwn-7686e3485253635c529cdd5f416fc640abaf076f.zip | |
ALSA: usx2y: Fix potential NULL dereference
The error handling code in usX2Y_rate_set() may hit a potential NULL
dereference when an error occurs before allocating all us->urb[].
Add a proper NULL check for fixing the corner case.
Reported-by: Lin Yi <teroincn@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20200420075529.27203-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/usb/usx2y/usbusx2yaudio.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c index 37d290fe9d43..ecaf41265dcd 100644 --- a/sound/usb/usx2y/usbusx2yaudio.c +++ b/sound/usb/usx2y/usbusx2yaudio.c @@ -681,6 +681,8 @@ static int usX2Y_rate_set(struct usX2Ydev *usX2Y, int rate) us->submitted = 2*NOOF_SETRATE_URBS; for (i = 0; i < NOOF_SETRATE_URBS; ++i) { struct urb *urb = us->urb[i]; + if (!urb) + continue; if (urb->status) { if (!err) err = -ENODEV; |