diff options
| author | Kangjie Lu <kangjielu@gmail.com> | 2016-05-03 16:44:20 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-10 12:54:44 +0200 |
| commit | 5b6fc00bb4ae7e917519b4fb49c9d3befa3897e5 (patch) | |
| tree | 2a320ce57fc545bfbeaa17e2901c85f55a752926 /sound | |
| parent | 82a638a293d7f0a699d88fe669a43829e65b0911 (diff) | |
| download | lwn-5b6fc00bb4ae7e917519b4fb49c9d3befa3897e5.tar.gz lwn-5b6fc00bb4ae7e917519b4fb49c9d3befa3897e5.zip | |
ALSA: timer: Fix leak in events via snd_timer_user_ccallback
commit 9a47e9cff994f37f7f0dbd9ae23740d0f64f9fe6 upstream.
The stack object “r1” has a total size of 32 bytes. Its field
“event” and “val” both contain 4 bytes padding. These 8 bytes
padding bytes are sent to user without being initialized.
Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/core/timer.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/core/timer.c b/sound/core/timer.c index 084a409f0c00..eb28b109d562 100644 --- a/sound/core/timer.c +++ b/sound/core/timer.c @@ -1225,6 +1225,7 @@ static void snd_timer_user_ccallback(struct snd_timer_instance *timeri, tu->tstamp = *tstamp; if ((tu->filter & (1 << event)) == 0 || !tu->tread) return; + memset(&r1, 0, sizeof(r1)); r1.event = event; r1.tstamp = *tstamp; r1.val = resolution; |