diff options
| author | Takashi Iwai <tiwai@suse.de> | 2016-02-01 12:04:55 +0100 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2016-02-15 15:45:30 -0500 |
| commit | 216b6d4f24b88ab70c58e0574e30b8da1b2b053b (patch) | |
| tree | a6c0052bf5c28a30c412859203a09e0bf7260e0c /sound | |
| parent | 81bce29eec26617db18ff21543c7a091b5c10c92 (diff) | |
| download | lwn-216b6d4f24b88ab70c58e0574e30b8da1b2b053b.tar.gz lwn-216b6d4f24b88ab70c58e0574e30b8da1b2b053b.zip | |
ALSA: rawmidi: Remove kernel WARNING for NULL user-space buffer check
[ Upstream commit cc85f7a634cfaf9f0713c6aa06d08817424db37a ]
NULL user-space buffer can be passed even in a normal path, thus it's
not good to spew a kernel warning with stack trace at each time.
Just drop snd_BUG_ON() macro usage there.
BugLink: http://lkml.kernel.org/r/CACT4Y+YfVJ3L+q0i-4vyQVyyPD7V=OMX0PWPi29x9Bo3QaBLdw@mail.gmail.com
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'sound')
| -rw-r--r-- | sound/core/rawmidi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/rawmidi.c b/sound/core/rawmidi.c index a7759846fbaa..f75d1656272c 100644 --- a/sound/core/rawmidi.c +++ b/sound/core/rawmidi.c @@ -1178,7 +1178,7 @@ static long snd_rawmidi_kernel_write1(struct snd_rawmidi_substream *substream, long count1, result; struct snd_rawmidi_runtime *runtime = substream->runtime; - if (snd_BUG_ON(!kernelbuf && !userbuf)) + if (!kernelbuf && !userbuf) return -EINVAL; if (snd_BUG_ON(!runtime->buffer)) return -EINVAL; |