summaryrefslogtreecommitdiff
path: root/sound
diff options
context:
space:
mode:
authorStephen Warren <swarren@nvidia.com>2014-02-13 16:54:24 -0700
committerJiri Slaby <jslaby@suse.cz>2014-03-31 14:22:28 +0200
commit9c831038cc7e6d2bc48034a6e8e328ed71cb7270 (patch)
tree697545f8f53449eb5dd1dbb214c6eded415fc4ba /sound
parentfcd6ba0f80c3b3fcad379e622a97477ae7065a71 (diff)
downloadlwn-9c831038cc7e6d2bc48034a6e8e328ed71cb7270.tar.gz
lwn-9c831038cc7e6d2bc48034a6e8e328ed71cb7270.zip
ASoC: max98090: make REVISION_ID readable
commit e126a646f77fdd66978785cb0a3a5e46b07aee2e upstream. The REVISION_ID register is not currently marked readable. snd_soc_read() refuses to read the register, and hence probe() fails. Fixes: d4807ad2c4c0 ("regmap: Check readable regs in _regmap_read") [exposed the bug, by checking for readability] Fixes: 685e42154dcf ("ASoC: Replace max98090 Device Driver") [left out this register from the readable list] Signed-off-by: Stephen Warren <swarren@nvidia.com> Signed-off-by: Mark Brown <broonie@linaro.org> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'sound')
-rw-r--r--sound/soc/codecs/max98090.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/sound/soc/codecs/max98090.c b/sound/soc/codecs/max98090.c
index 5f728808eed4..8bddf3f20a5e 100644
--- a/sound/soc/codecs/max98090.c
+++ b/sound/soc/codecs/max98090.c
@@ -336,6 +336,7 @@ static bool max98090_readable_register(struct device *dev, unsigned int reg)
case M98090_REG_RECORD_TDM_SLOT:
case M98090_REG_SAMPLE_RATE:
case M98090_REG_DMIC34_BIQUAD_BASE ... M98090_REG_DMIC34_BIQUAD_BASE + 0x0E:
+ case M98090_REG_REVISION_ID:
return true;
default:
return false;