diff options
| author | Tim Gardner <tim.gardner@canonical.com> | 2014-04-09 11:30:44 -0600 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2014-07-18 15:51:10 +0200 |
| commit | eae433b4f393fb3c4a0d806674f4b89536530360 (patch) | |
| tree | 6962a2bb75b7cb94acf51beefcd4779c446edc0d /sound/usb | |
| parent | c9fcc0e38ff846a043218e4c7ec326b90a3f78a6 (diff) | |
| download | lwn-eae433b4f393fb3c4a0d806674f4b89536530360.tar.gz lwn-eae433b4f393fb3c4a0d806674f4b89536530360.zip | |
ALSA: usb-audio: Suppress repetitive debug messages from retire_playback_urb()
commit a5065eb6da55b226661456e6a7435f605df98111 upstream.
BugLink: http://bugs.launchpad.net/bugs/1305133
Malfunctioning or slow devices can cause a flood of dmesg SPAM.
I've ignored checkpatch.pl complaints about the use of printk_ratelimit() in favour
of prior art in sound/usb/pcm.c.
WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit
+ if (printk_ratelimit() &&
Cc: Jaroslav Kysela <perex@perex.cz>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Eldad Zack <eldad@fogrefinery.com>
Cc: Daniel Mack <zonque@gmail.com>
Cc: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'sound/usb')
| -rw-r--r-- | sound/usb/pcm.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c index b375d58871e7..d59e0c1a3e20 100644 --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -1491,7 +1491,8 @@ static void retire_playback_urb(struct snd_usb_substream *subs, * The error should be lower than 2ms since the estimate relies * on two reads of a counter updated every ms. */ - if (abs(est_delay - subs->last_delay) * 1000 > runtime->rate * 2) + if (printk_ratelimit() && + abs(est_delay - subs->last_delay) * 1000 > runtime->rate * 2) snd_printk(KERN_DEBUG "delay: estimated %d, actual %d\n", est_delay, subs->last_delay); |