diff options
| author | Takashi Sakamoto <o-takashi@sakamocchi.jp> | 2016-09-27 07:45:07 +0900 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2016-09-27 09:49:13 -0700 |
| commit | a56a569818ea831ed2325dc5d1122dc0b8a229d0 (patch) | |
| tree | 35e9302a24accf3ba1f87cfa588f41f0c583c9bf /sound/soc | |
| parent | bb0c35fcaf8f2ad3383dd43ca8abf5203cd06cc3 (diff) | |
| download | lwn-a56a569818ea831ed2325dc5d1122dc0b8a229d0.tar.gz lwn-a56a569818ea831ed2325dc5d1122dc0b8a229d0.zip | |
ASoC: da7219: fix inappropriate condition statement
Sparse reports a below warning.
sound/soc/codecs/da7219.c:804:57: warning: dubious: x & !y
The line includes a condition statement; '(a < b) & !c'. Practically, the
evaluated value of this statement equals to the value of '(a < b) && !c'.
Although, it's not an usual way to use bitwise operations as logical
operations to several conditions.
This commit fixes the bug.
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc')
| -rw-r--r-- | sound/soc/codecs/da7219.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c index 65f7e9807659..32007625913d 100644 --- a/sound/soc/codecs/da7219.c +++ b/sound/soc/codecs/da7219.c @@ -801,7 +801,7 @@ static int da7219_dai_event(struct snd_soc_dapm_widget *w, ++i; msleep(50); } - } while ((i < DA7219_SRM_CHECK_RETRIES) & (!srm_lock)); + } while ((i < DA7219_SRM_CHECK_RETRIES) && (!srm_lock)); if (!srm_lock) dev_warn(codec->dev, "SRM failed to lock\n"); |