diff options
| author | Nicolin Chen <b42378@freescale.com> | 2013-12-04 11:18:36 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2013-12-04 11:46:40 +0000 |
| commit | 7f62b6ee767586ee7e5d12787dbaaaf47a91979a (patch) | |
| tree | 055283483fcd0017497c9e9caa68fdbe3afd07c4 /sound/soc | |
| parent | ebff65473f56e6c30de928fd6a4f1ce5ae36e8c5 (diff) | |
| download | lwn-7f62b6ee767586ee7e5d12787dbaaaf47a91979a.tar.gz lwn-7f62b6ee767586ee7e5d12787dbaaaf47a91979a.zip | |
ASoC: soc-pcm: Use valid condition for snd_soc_dai_digital_mute() in hw_free()
The snd_soc_dai_digital_mute() here will be never executed because we only
decrease codec->active in snd_soc_close(). Thus correct it.
Signed-off-by: Nicolin Chen <b42378@freescale.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound/soc')
| -rw-r--r-- | sound/soc/soc-pcm.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c index 11a90cd027fa..891b9a9bcbf8 100644 --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -600,12 +600,13 @@ static int soc_pcm_hw_free(struct snd_pcm_substream *substream) struct snd_soc_platform *platform = rtd->platform; struct snd_soc_dai *cpu_dai = rtd->cpu_dai; struct snd_soc_dai *codec_dai = rtd->codec_dai; - struct snd_soc_codec *codec = rtd->codec; + bool playback = substream->stream == SNDRV_PCM_STREAM_PLAYBACK; mutex_lock_nested(&rtd->pcm_mutex, rtd->pcm_subclass); /* apply codec digital mute */ - if (!codec->active) + if ((playback && codec_dai->playback_active == 1) || + (!playback && codec_dai->capture_active == 1)) snd_soc_dai_digital_mute(codec_dai, 1, substream->stream); /* free any machine hw params */ |