diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2013-08-27 15:51:00 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2013-08-27 15:39:43 +0100 |
| commit | 8c193b8dce4f2a2474dc2bc39ec972454df9d439 (patch) | |
| tree | fb8dd4397f57e87488d14e0247783b42aacabca1 /sound/soc/soc-core.c | |
| parent | 4b52fa211a7c65eab78acf3f434361d40de87688 (diff) | |
| download | lwn-8c193b8dce4f2a2474dc2bc39ec972454df9d439.tar.gz lwn-8c193b8dce4f2a2474dc2bc39ec972454df9d439.zip | |
ASoC: Move call to snd_soc_dapm_new_widgets() after snd_soc_dapm_auto_nc_codec_pins()
Call snd_soc_dapm_new_widgets() before the auto non-connected pins have been
marked as not connected will power the system under the assumption that those
pins are connected. Once the pins have been marked as disconnected the system
there will be an additional power run. This can cause unnecessary power
transitions. Calling snd_soc_dapm_new_widgets() only after the pins have been
marked as non-connected avoids this.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'sound/soc/soc-core.c')
| -rw-r--r-- | sound/soc/soc-core.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 85e2a8b8f288..9375012ccb21 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1803,12 +1803,12 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card) } } - snd_soc_dapm_new_widgets(&card->dapm); - if (card->fully_routed) list_for_each_entry(codec, &card->codec_dev_list, card_list) snd_soc_dapm_auto_nc_codec_pins(codec); + snd_soc_dapm_new_widgets(&card->dapm); + ret = snd_card_register(card->snd_card); if (ret < 0) { dev_err(card->dev, "ASoC: failed to register soundcard %d\n", |