diff options
| author | Peter Ujfalusi <peter.ujfalusi@linux.intel.com> | 2021-10-13 15:33:00 +0300 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-10-13 16:26:15 +0100 |
| commit | f05a9b8552896d95fc22e135eaf9c6be541bfe79 (patch) | |
| tree | 7e509110af6b725c75626d2f8b7e7123c51f3c4f /sound/soc/codecs/rt5682.c | |
| parent | 51a67d6e28c6e1f10c8ef95b4f5fbf204ebbeb24 (diff) | |
| download | lwn-f05a9b8552896d95fc22e135eaf9c6be541bfe79.tar.gz lwn-f05a9b8552896d95fc22e135eaf9c6be541bfe79.zip | |
ASoC: rt1011: Fix 'I2S Reference' enum control
There are several things the patch adding the support for 'I2S Reference'
got wrong:
- "None" selection is in fact equals to last selected reference
- The custom put overrides RX/TX len, TDM slot sizes, etc
- the enum is useless in most part for the reference tracking
- there is no need for EXT control as there is a single bit in
RT1011_TDM1_SET_1 register (bit 7) which selects the reference
- it was using ucontrol->value.integer.value[0] in the put/get callbacks
which causesed access to 'I2S Reference' enum with alsamixer to fail
Complements: c3de683c4d1d ("ASoC: rt1011: Fix 'I2S Reference' enum control caused error")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20211013123300.11095-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/soc/codecs/rt5682.c')
0 files changed, 0 insertions, 0 deletions