diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-15 16:04:53 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-03-20 13:06:58 +0000 |
| commit | e3a8459d726532be70fa917e39812570618b857e (patch) | |
| tree | 2998035c831469e7e6c0ebdd3588030520b6a460 /sound/sh | |
| parent | e32acf7b00ba0893532d44f3dba34bb1efeafeb3 (diff) | |
| download | lwn-e3a8459d726532be70fa917e39812570618b857e.tar.gz lwn-e3a8459d726532be70fa917e39812570618b857e.zip | |
ALSA: sh: aica: Drop if blocks with always false condition
snd_aica_remove() is only called after a successful call to
snd_aica_probe(). With the latter it's sure that platform_set_drvdata()
was called with a non-NULL argument. So platform_get_drvdata() won't return
NULL and the check can be dropped.
This prepares converting platform driver remove callbacks to return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'sound/sh')
| -rw-r--r-- | sound/sh/aica.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sound/sh/aica.c b/sound/sh/aica.c index 6e9d6bd67369..459c907655d9 100644 --- a/sound/sh/aica.c +++ b/sound/sh/aica.c @@ -543,8 +543,6 @@ static int snd_aica_remove(struct platform_device *devptr) { struct snd_card_aica *dreamcastcard; dreamcastcard = platform_get_drvdata(devptr); - if (unlikely(!dreamcastcard)) - return -ENODEV; snd_card_free(dreamcastcard->card); kfree(dreamcastcard); return 0; |