diff options
| author | Takashi Iwai <tiwai@suse.de> | 2016-09-21 14:38:02 +0200 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-10-17 09:46:19 +0200 |
| commit | b3b34980847468b6bb0b26b3909e514a1c47d383 (patch) | |
| tree | 5f6d96648fcb3821a1a2bdd69fbf41c25bd0ca11 /sound/pci | |
| parent | cf28bd0ce8c6f14374c8747bbcb73f1d0afd6d91 (diff) | |
| download | lwn-b3b34980847468b6bb0b26b3909e514a1c47d383.tar.gz lwn-b3b34980847468b6bb0b26b3909e514a1c47d383.zip | |
ALSA: ali5451: Fix out-of-bound position reporting
commit db68577966abc1aeae4ec597b3dcfa0d56e92041 upstream.
The pointer callbacks of ali5451 driver may return the value at the
boundary occasionally, and it results in the kernel warning like
snd_ali5451 0000:00:06.0: BUG: , pos = 16384, buffer size = 16384, period size = 1024
It seems that folding the position offset is enough for fixing the
warning and no ill-effect has been seen by that.
Reported-by: Enrico Mioso <mrkiko.rs@gmail.com>
Tested-by: Enrico Mioso <mrkiko.rs@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'sound/pci')
| -rw-r--r-- | sound/pci/ali5451/ali5451.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sound/pci/ali5451/ali5451.c b/sound/pci/ali5451/ali5451.c index 3dfa12b670eb..5778eceb41fd 100644 --- a/sound/pci/ali5451/ali5451.c +++ b/sound/pci/ali5451/ali5451.c @@ -1422,6 +1422,7 @@ snd_ali_playback_pointer(struct snd_pcm_substream *substream) spin_unlock(&codec->reg_lock); snd_ali_printk("playback pointer returned cso=%xh.\n", cso); + cso %= runtime->buffer_size; return cso; } @@ -1442,6 +1443,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream) cso = inw(ALI_REG(codec, ALI_CSO_ALPHA_FMS + 2)); spin_unlock(&codec->reg_lock); + cso %= runtime->buffer_size; return cso; } |