diff options
| author | Ondrej Zary <linux@rainbow-software.org> | 2015-11-01 20:53:14 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2015-11-02 08:46:30 +0100 |
| commit | 2c8d08925272b9be383cd81f1973c6faf9fbf53a (patch) | |
| tree | 6e012daa67c9e027e3505ec366a41f2800d63af1 /sound/pci/maestro3.c | |
| parent | 030270ba1aa2072d2967c11129c67d9de9aa762b (diff) | |
| download | lwn-2c8d08925272b9be383cd81f1973c6faf9fbf53a.tar.gz lwn-2c8d08925272b9be383cd81f1973c6faf9fbf53a.zip | |
ALSA: maestro3: Fix Allegro mute until master volume/mute is touched
ESS Allegro (marked ES1989S), [125d:1988] (rev 10) is mute after
loading snd-maestro3 and running alsactl restore. Touching master
volume or mute makes it work.
Looks like a bug in the AC'97 codec integrated into the chip.
Write AC97_MASTER register twice to work-around the problem.
Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/pci/maestro3.c')
| -rw-r--r-- | sound/pci/maestro3.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/sound/pci/maestro3.c b/sound/pci/maestro3.c index 965d5c6f2fa0..17ae92613de4 100644 --- a/sound/pci/maestro3.c +++ b/sound/pci/maestro3.c @@ -1929,6 +1929,16 @@ snd_m3_ac97_write(struct snd_ac97 *ac97, unsigned short reg, unsigned short val) return; snd_m3_outw(chip, val, CODEC_DATA); snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND); + /* + * Workaround for buggy ES1988 integrated AC'97 codec. It remains silent + * until the MASTER volume or mute is touched (alsactl restore does not + * work). + */ + if (ac97->id == 0x45838308 && reg == AC97_MASTER) { + snd_m3_ac97_wait(chip); + snd_m3_outw(chip, val, CODEC_DATA); + snd_m3_outb(chip, reg & 0x7f, CODEC_COMMAND); + } } |