diff options
| author | Takashi Iwai <tiwai@suse.de> | 2019-02-04 16:31:42 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2019-02-06 10:29:03 +0100 |
| commit | f32e5616005bb999fec6a2e914161805d7ad061f (patch) | |
| tree | 5b56938661de0380015dd7ac9dc88d430bf7636e /sound/parisc | |
| parent | e6e8c82b97472c4e02a314e7161f980534e7bca5 (diff) | |
| download | lwn-f32e5616005bb999fec6a2e914161805d7ad061f.tar.gz lwn-f32e5616005bb999fec6a2e914161805d7ad061f.zip | |
ALSA: parisc: Drop superfluous PCM preallocation error checks
snd_pcm_lib_preallocate_pages() and co always succeed, so the error
check is simply redundant. Drop it.
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/parisc')
| -rw-r--r-- | sound/parisc/harmony.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/sound/parisc/harmony.c b/sound/parisc/harmony.c index f36e7006e00c..a4264b8943f0 100644 --- a/sound/parisc/harmony.c +++ b/sound/parisc/harmony.c @@ -669,14 +669,8 @@ snd_harmony_pcm_init(struct snd_harmony *h) } /* pre-allocate space for DMA */ - err = snd_pcm_lib_preallocate_pages_for_all(pcm, h->dma.type, - h->dma.dev, - MAX_BUF_SIZE, - MAX_BUF_SIZE); - if (err < 0) { - printk(KERN_ERR PFX "buffer allocation error: %d\n", err); - return err; - } + snd_pcm_lib_preallocate_pages_for_all(pcm, h->dma.type, h->dma.dev, + MAX_BUF_SIZE, MAX_BUF_SIZE); h->st.format = snd_harmony_set_data_format(h, SNDRV_PCM_FORMAT_S16_BE, 1); |