diff options
| author | Takashi Iwai <tiwai@suse.de> | 2022-05-10 12:36:26 +0200 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2022-05-10 16:26:45 +0200 |
| commit | a34ae6c0660d3b96b0055f68ef74dc9478852245 (patch) | |
| tree | 69bd517778abc05b3a2aa00d1bbab344cf1369e8 /sound/isa | |
| parent | 1efcdd9c1f34f5a6590bc9ac5471e562fb011386 (diff) | |
| download | lwn-a34ae6c0660d3b96b0055f68ef74dc9478852245.tar.gz lwn-a34ae6c0660d3b96b0055f68ef74dc9478852245.zip | |
ALSA: wavefront: Proper check of get_user() error
The antient ISA wavefront driver reads its sample patch data (uploaded
over an ioctl) via __get_user() with no good reason; likely just for
some performance optimizations in the past. Let's change this to the
standard get_user() and the error check for handling the fault case
properly.
Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220510103626.16635-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/isa')
| -rw-r--r-- | sound/isa/wavefront/wavefront_synth.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sound/isa/wavefront/wavefront_synth.c b/sound/isa/wavefront/wavefront_synth.c index 69cbc79fbb71..2aaaa6807174 100644 --- a/sound/isa/wavefront/wavefront_synth.c +++ b/sound/isa/wavefront/wavefront_synth.c @@ -1094,7 +1094,8 @@ wavefront_send_sample (snd_wavefront_t *dev, if (dataptr < data_end) { - __get_user (sample_short, dataptr); + if (get_user(sample_short, dataptr)) + return -EFAULT; dataptr += skip; if (data_is_unsigned) { /* GUS ? */ |