diff options
| author | Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> | 2016-04-19 12:54:18 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-10-07 15:21:27 +0200 |
| commit | 8e20d9300ac8d29bd5ce8f9e6f635af2c696bab8 (patch) | |
| tree | dbff8d9ca984663ac5cd46416fb0d47d13dd2d03 /sound/drivers/opl3 | |
| parent | 5a58005763c3e66468814706eeb79999525a6cf5 (diff) | |
| download | lwn-8e20d9300ac8d29bd5ce8f9e6f635af2c696bab8.tar.gz lwn-8e20d9300ac8d29bd5ce8f9e6f635af2c696bab8.zip | |
tpm_crb: fix mapping of the buffers
commit 422eac3f7deae34dbaffd08e03e27f37a5394a56 upstream.
On my Lenovo x250 the following situation occurs:
[18697.813871] tpm_crb MSFT0101:00: can't request region for resource
[mem 0xacdff080-0xacdfffff]
The mapping of the control area overlaps the mapping of the command
buffer. The control area is mapped over page, which is not right. It
should mapped over sizeof(struct crb_control_area).
Fixing this issue unmasks another issue. Command and response buffers
can overlap and they do interleave on this machine. According to the PTP
specification the overlapping means that they are mapped to the same
buffer.
The commit has been also on a Haswell NUC where things worked before
applying this fix so that the both code paths for response buffer
initialization are tested.
Cc: stable@vger.kernel.org
Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'sound/drivers/opl3')
0 files changed, 0 insertions, 0 deletions