diff options
| author | Sachin Kamat <sachin.kamat@linaro.org> | 2012-11-21 14:36:55 +0530 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2012-11-21 10:43:35 +0100 |
| commit | 6cf95152079d7c6d7ba6442be45e02b24bbb1c65 (patch) | |
| tree | 6facb32890a27b8ccd1265c6a2f42bd3e73e755a /sound/core | |
| parent | 51d503de0210a2b800efdedee23580011f5422c3 (diff) | |
| download | lwn-6cf95152079d7c6d7ba6442be45e02b24bbb1c65.tar.gz lwn-6cf95152079d7c6d7ba6442be45e02b24bbb1c65.zip | |
ALSA: pcm: Fix return code in pcm_native.c
Return the value obtained from snd_pcm_hw_constraint_minmax() instead
of -EINVAL. Silences the following smatch warning:
sound/core/pcm_native.c:2003 snd_pcm_hw_constraints_complete() info:
why not propagate 'err' from snd_pcm_hw_constraint_minmax() instead of -22?
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/core')
| -rw-r--r-- | sound/core/pcm_native.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c index c76f6375a96b..09b4286c65f9 100644 --- a/sound/core/pcm_native.c +++ b/sound/core/pcm_native.c @@ -2000,7 +2000,7 @@ int snd_pcm_hw_constraints_complete(struct snd_pcm_substream *substream) if (runtime->dma_bytes) { err = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_BUFFER_BYTES, 0, runtime->dma_bytes); if (err < 0) - return -EINVAL; + return err; } if (!(hw->rates & (SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_CONTINUOUS))) { |