diff options
| author | Takashi Iwai <tiwai@suse.de> | 2019-02-18 14:38:06 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2019-02-19 22:20:14 +0100 |
| commit | 31d2350d602511efc9ef626b848fe521233b0387 (patch) | |
| tree | b43a004188f1edb233b15dfa83a03f0158bfb7d0 /sound/ac97 | |
| parent | c7a13264918b9796f80c634f20fea56e1612572d (diff) | |
| download | lwn-31d2350d602511efc9ef626b848fe521233b0387.tar.gz lwn-31d2350d602511efc9ef626b848fe521233b0387.zip | |
ALSA: ac97: Fix of-node refcount unbalance
ac97_of_get_child_device() take the refcount of the node explicitly
via of_node_get(), but this leads to an unbalance. The
for_each_child_of_node() loop itself takes the refcount for each
iteration node, hence you don't need to take the extra refcount
again.
Fixes: 2225a3e6af78 ("ALSA: ac97: add codecs devicetree binding")
Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'sound/ac97')
| -rw-r--r-- | sound/ac97/bus.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/ac97/bus.c b/sound/ac97/bus.c index 9f0c480489ef..9cbf6927abe9 100644 --- a/sound/ac97/bus.c +++ b/sound/ac97/bus.c @@ -84,7 +84,7 @@ ac97_of_get_child_device(struct ac97_controller *ac97_ctrl, int idx, if ((idx != of_property_read_u32(node, "reg", ®)) || !of_device_is_compatible(node, compat)) continue; - return of_node_get(node); + return node; } return NULL; |