summaryrefslogtreecommitdiff
path: root/security
diff options
context:
space:
mode:
authorLaurent Georget <laurent.georget@supelec.fr>2016-07-13 08:58:40 +0200
committerJiri Kosina <jkosina@suse.cz>2016-09-29 10:07:01 +0200
commit1b4606511d11075a2cb61485b359555aba65fc2d (patch)
treeafbb12d02307e7c77087fdca9baafaae7e07a285 /security
parent3da7ffecb778a39c6ec895752a4918331957acd3 (diff)
downloadlwn-1b4606511d11075a2cb61485b359555aba65fc2d.tar.gz
lwn-1b4606511d11075a2cb61485b359555aba65fc2d.zip
securityfs: fix securityfs_create_dir comment
If there is an error creating a directory with securityfs_create_dir, the error is propagated via ERR_PTR but the function comment claims that NULL is returned. This is a similar commit to 88e6c94cda322ff2b32f72bb8d96f9675cdad8aa ("fix long-broken securityfs_create_file comment") that did not fix securityfs_create_dir comment at the same time. Signed-off-by: Laurent Georget <laurent.georget@supelec.fr> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Diffstat (limited to 'security')
-rw-r--r--security/inode.c7
1 files changed, 3 insertions, 4 deletions
diff --git a/security/inode.c b/security/inode.c
index 28414b0207ce..a09639bd1398 100644
--- a/security/inode.c
+++ b/security/inode.c
@@ -156,12 +156,11 @@ EXPORT_SYMBOL_GPL(securityfs_create_file);
* This function returns a pointer to a dentry if it succeeds. This
* pointer must be passed to the securityfs_remove() function when the file is
* to be removed (no automatic cleanup happens if your module is unloaded,
- * you are responsible here). If an error occurs, %NULL will be returned.
+ * you are responsible here). If an error occurs, the function will return
+ * the error value (via ERR_PTR).
*
* If securityfs is not enabled in the kernel, the value %-ENODEV is
- * returned. It is not wise to check for this value, but rather, check for
- * %NULL or !%NULL instead as to eliminate the need for #ifdef in the calling
- * code.
+ * returned.
*/
struct dentry *securityfs_create_dir(const char *name, struct dentry *parent)
{