diff options
| author | Xin Xiong <xiongx18@fudan.edu.cn> | 2022-04-28 11:39:08 +0800 |
|---|---|---|
| committer | John Johansen <john.johansen@canonical.com> | 2022-07-09 15:13:59 -0700 |
| commit | 11c3627ec6b56c1525013f336f41b79a983b4d46 (patch) | |
| tree | 0f68d3c99a74ef6e88371d3663d8fa9f9595ac11 /security | |
| parent | bab1f77fb815374e9d092a72d5a2abc7c943bca3 (diff) | |
| download | lwn-11c3627ec6b56c1525013f336f41b79a983b4d46.tar.gz lwn-11c3627ec6b56c1525013f336f41b79a983b4d46.zip | |
apparmor: fix reference count leak in aa_pivotroot()
The aa_pivotroot() function has a reference counting bug in a specific
path. When aa_replace_current_label() returns on success, the function
forgets to decrement the reference count of “target”, which is
increased earlier by build_pivotroot(), causing a reference leak.
Fix it by decreasing the refcount of “target” in that path.
Fixes: 2ea3ffb7782a ("apparmor: add mount mediation")
Co-developed-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Co-developed-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: John Johansen <john.johansen@canonical.com>
Diffstat (limited to 'security')
| -rw-r--r-- | security/apparmor/mount.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/security/apparmor/mount.c b/security/apparmor/mount.c index 5cc5de062fc8..fa64a2db3aec 100644 --- a/security/apparmor/mount.c +++ b/security/apparmor/mount.c @@ -719,6 +719,7 @@ int aa_pivotroot(struct aa_label *label, const struct path *old_path, aa_put_label(target); goto out; } + aa_put_label(target); } else /* already audited error */ error = PTR_ERR(target); |