diff options
author | Alexander Lochmann <alexander.lochmann@tu-dortmund.de> | 2018-12-14 11:55:52 +0100 |
---|---|---|
committer | Al Viro <viro@zeniv.linux.org.uk> | 2019-04-28 21:46:57 -0400 |
commit | f69e749a49353d96af1a293f56b5b56de59c668a (patch) | |
tree | ccf6a64b148cfc4102dade591f0139a597bbbb34 /security | |
parent | ee948837d7fa89127373c139766aacf6b02a9225 (diff) | |
download | lwn-f69e749a49353d96af1a293f56b5b56de59c668a.tar.gz lwn-f69e749a49353d96af1a293f56b5b56de59c668a.zip |
Abort file_remove_privs() for non-reg. files
file_remove_privs() might be called for non-regular files, e.g.
blkdev inode. There is no reason to do its job on things
like blkdev inodes, pipes, or cdevs. Hence, abort if
file does not refer to a regular inode.
AV: more to the point, for devices there might be any number of
inodes refering to given device. Which one to strip the permissions
from, even if that made any sense in the first place? All of them
will be observed with contents modified, after all.
Found by LockDoc (Alexander Lochmann, Horst Schirmeier and Olaf
Spinczyk)
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
Signed-off-by: Horst Schirmeier <horst.schirmeier@tu-dortmund.de>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'security')
0 files changed, 0 insertions, 0 deletions