diff options
| author | Dan Carpenter <error27@gmail.com> | 2010-04-22 12:05:35 +0200 |
|---|---|---|
| committer | James Morris <jmorris@namei.org> | 2010-04-22 21:17:41 +1000 |
| commit | b338cc8207eae46640a8d534738fda7b5e48511d (patch) | |
| tree | 13ce72ed8e2a83ce127c3380ba0a7084591db3ab /security | |
| parent | e134d200d57d43b171dcb0b55c178a1a0c7db14a (diff) | |
| download | lwn-b338cc8207eae46640a8d534738fda7b5e48511d.tar.gz lwn-b338cc8207eae46640a8d534738fda7b5e48511d.zip | |
security: testing the wrong variable in create_by_name()
There is a typo here. We should be testing "*dentry" instead of
"dentry". If "*dentry" is an ERR_PTR, it gets dereferenced in either
mkdir() or create() which would cause an OOPs.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: James Morris <jmorris@namei.org>
Diffstat (limited to 'security')
| -rw-r--r-- | security/inode.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/security/inode.c b/security/inode.c index c3a793881d04..1c812e874504 100644 --- a/security/inode.c +++ b/security/inode.c @@ -161,13 +161,13 @@ static int create_by_name(const char *name, mode_t mode, mutex_lock(&parent->d_inode->i_mutex); *dentry = lookup_one_len(name, parent, strlen(name)); - if (!IS_ERR(dentry)) { + if (!IS_ERR(*dentry)) { if ((mode & S_IFMT) == S_IFDIR) error = mkdir(parent->d_inode, *dentry, mode); else error = create(parent->d_inode, *dentry, mode); } else - error = PTR_ERR(dentry); + error = PTR_ERR(*dentry); mutex_unlock(&parent->d_inode->i_mutex); return error; |