diff options
| author | Jesper Juhl <jesper.juhl@gmail.com> | 2007-07-21 00:12:44 +0200 |
|---|---|---|
| committer | James Morris <jmorris@namei.org> | 2007-07-23 09:35:37 -0400 |
| commit | 0ec8abd7086ee4f760cb1b477fe376805b17558c (patch) | |
| tree | 09eff2e119de344244242788eab5b6514191f040 /security/selinux | |
| parent | f695baf2df9e0413d3521661070103711545207a (diff) | |
| download | lwn-0ec8abd7086ee4f760cb1b477fe376805b17558c.tar.gz lwn-0ec8abd7086ee4f760cb1b477fe376805b17558c.zip | |
SELinux: fix memory leak in security_netlbl_cache_add()
Fix memory leak in security_netlbl_cache_add()
Note: The Coverity checker gets credit for spotting this one.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
Signed-off-by: James Morris <jmorris@namei.org>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Diffstat (limited to 'security/selinux')
| -rw-r--r-- | security/selinux/ss/services.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c index b5f017f07a75..0ae032f3876b 100644 --- a/security/selinux/ss/services.c +++ b/security/selinux/ss/services.c @@ -2417,8 +2417,10 @@ static void security_netlbl_cache_add(struct netlbl_lsm_secattr *secattr, cache->type = NETLBL_CACHE_T_MLS; if (ebitmap_cpy(&cache->data.mls_label.level[0].cat, - &ctx->range.level[0].cat) != 0) + &ctx->range.level[0].cat) != 0) { + kfree(cache); return; + } cache->data.mls_label.level[1].cat.highbit = cache->data.mls_label.level[0].cat.highbit; cache->data.mls_label.level[1].cat.node = |