diff options
| author | John Johansen <john.johansen@canonical.com> | 2019-08-29 11:35:50 -0700 |
|---|---|---|
| committer | John Johansen <john.johansen@canonical.com> | 2020-01-21 06:00:20 -0800 |
| commit | 01df52d726b5d55d2970f5c957f1961930acd5d6 (patch) | |
| tree | c41b7d17843182e72191740c22719a261b94254a /security/apparmor | |
| parent | 0df34a645bae00c86f383fb063cd3840862837bf (diff) | |
| download | lwn-01df52d726b5d55d2970f5c957f1961930acd5d6.tar.gz lwn-01df52d726b5d55d2970f5c957f1961930acd5d6.zip | |
apparmor: remove duplicate check of xattrs on profile attachment.
The second check to ensure the xattrs are present and checked is
unneeded as this is already done in the profile attachment xmatch.
Signed-off-by: John Johansen <john.johansen@canonical.com>
Diffstat (limited to 'security/apparmor')
| -rw-r--r-- | security/apparmor/domain.c | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/security/apparmor/domain.c b/security/apparmor/domain.c index 0a91d5f7d0e9..0926553ca86f 100644 --- a/security/apparmor/domain.c +++ b/security/apparmor/domain.c @@ -625,8 +625,6 @@ static struct aa_label *profile_transition(struct aa_profile *profile, bool *secure_exec) { struct aa_label *new = NULL; - struct aa_profile *component; - struct label_it i; const char *info = NULL, *name = NULL, *target = NULL; unsigned int state = profile->file.start; struct aa_perms perms = {}; @@ -675,21 +673,6 @@ static struct aa_label *profile_transition(struct aa_profile *profile, info = "profile transition not found"; /* remove MAY_EXEC to audit as failure */ perms.allow &= ~MAY_EXEC; - } else { - /* verify that each component's xattr requirements are - * met, and fail execution otherwise - */ - label_for_each(i, new, component) { - if (aa_xattrs_match(bprm, component, state) < - 0) { - error = -EACCES; - info = "required xattrs not present"; - perms.allow &= ~MAY_EXEC; - aa_put_label(new); - new = NULL; - goto audit; - } - } } } else if (COMPLAIN_MODE(profile)) { /* no exec permission - learning mode */ |