diff options
| author | Jeremie Francois (on alpha) <jeremie.francois@gmail.com> | 2020-04-10 18:57:40 +0200 |
|---|---|---|
| committer | Masahiro Yamada <masahiroy@kernel.org> | 2020-04-23 01:10:16 +0900 |
| commit | e461bc9f9ab105637b86065d24b0b83f182d477c (patch) | |
| tree | 10e5d0193bcb7c27802f72924143531d79cf9e83 /scripts | |
| parent | ae83d0b416db002fe95601e7f97f64b59514d936 (diff) | |
| download | lwn-e461bc9f9ab105637b86065d24b0b83f182d477c.tar.gz lwn-e461bc9f9ab105637b86065d24b0b83f182d477c.zip | |
scripts/config: allow colons in option strings for sed
Sed broke on some strings as it used colon as a separator.
I made it more robust by using \001, which is legit POSIX AFAIK.
E.g. ./config --set-str CONFIG_USBNET_DEVADDR "de:ad:be:ef:00:01"
failed with: sed: -e expression #1, char 55: unknown option to `s'
Signed-off-by: Jeremie Francois (on alpha) <jeremie.francois@gmail.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts')
| -rwxr-xr-x | scripts/config | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/scripts/config b/scripts/config index e0e39826dae9..eee5b7f3a092 100755 --- a/scripts/config +++ b/scripts/config @@ -7,6 +7,9 @@ myname=${0##*/} # If no prefix forced, use the default CONFIG_ CONFIG_="${CONFIG_-CONFIG_}" +# We use an uncommon delimiter for sed substitutions +SED_DELIM=$(echo -en "\001") + usage() { cat >&2 <<EOL Manipulate options in a .config file from the command line. @@ -83,7 +86,7 @@ txt_subst() { local infile="$3" local tmpfile="$infile.swp" - sed -e "s:$before:$after:" "$infile" >"$tmpfile" + sed -e "s$SED_DELIM$before$SED_DELIM$after$SED_DELIM" "$infile" >"$tmpfile" # replace original file with the edited one mv "$tmpfile" "$infile" } |