diff options
author | Jessica Yu <jeyu@kernel.org> | 2020-03-06 17:02:05 +0100 |
---|---|---|
committer | Masahiro Yamada <masahiroy@kernel.org> | 2020-03-13 10:04:36 +0900 |
commit | 93c95e526a4ef00eb3d5a1e0920ba5a22f32e40d (patch) | |
tree | ef8aeabe63b764b57e4635ffbf1cdf032f3c0e99 /scripts/mod/modpost.h | |
parent | 9dffecc1339b1f446213a9ba2f19579d9db4d7c7 (diff) | |
download | lwn-93c95e526a4ef00eb3d5a1e0920ba5a22f32e40d.tar.gz lwn-93c95e526a4ef00eb3d5a1e0920ba5a22f32e40d.zip |
modpost: rework and consolidate logging interface
Rework modpost's logging interface by consolidating merror(), warn(), and
fatal() to use a single function, modpost_log(). Introduce different
logging levels (WARN, ERROR, FATAL) as well. The purpose of this cleanup is
to reduce code duplication when deciding whether or not to warn or error
out based on a condition.
Signed-off-by: Jessica Yu <jeyu@kernel.org>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'scripts/mod/modpost.h')
-rw-r--r-- | scripts/mod/modpost.h | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/scripts/mod/modpost.h b/scripts/mod/modpost.h index 64a82d2d85f6..60dca9b7106b 100644 --- a/scripts/mod/modpost.h +++ b/scripts/mod/modpost.h @@ -198,6 +198,14 @@ void *grab_file(const char *filename, unsigned long *size); char* get_next_line(unsigned long *pos, void *file, unsigned long size); void release_file(void *file, unsigned long size); -void fatal(const char *fmt, ...); -void warn(const char *fmt, ...); -void merror(const char *fmt, ...); +enum loglevel { + LOG_WARN, + LOG_ERROR, + LOG_FATAL +}; + +void modpost_log(enum loglevel loglevel, const char *fmt, ...); + +#define warn(fmt, args...) modpost_log(LOG_WARN, fmt, ##args) +#define merror(fmt, args...) modpost_log(LOG_ERROR, fmt, ##args) +#define fatal(fmt, args...) modpost_log(LOG_FATAL, fmt, ##args) |