diff options
| author | Greg Kroah-Hartman <gregkh@suse.de> | 2008-07-23 21:29:04 -0700 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2008-07-24 10:47:26 -0700 |
| commit | 4c432a8f0134504814aa8dcce6cc57c89d175604 (patch) | |
| tree | ebc15ff444ec24098c18ec6c0210ea33333f40d3 /scripts/checkpatch.pl | |
| parent | f5fe35dd95549b1b419cdeb2ec3fe61fda94fa93 (diff) | |
| download | lwn-4c432a8f0134504814aa8dcce6cc57c89d175604.tar.gz lwn-4c432a8f0134504814aa8dcce6cc57c89d175604.zip | |
checkpatch: usb_free_urb() can take NULL
usb_free_urb() can take a NULL, so let's check and warn about that.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/checkpatch.pl')
| -rwxr-xr-x | scripts/checkpatch.pl | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 13d7a330b5dd..a4e8087a0cae 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2078,6 +2078,13 @@ sub process { WARN("kfree(NULL) is safe this check is probabally not required\n" . $hereprev); } } +# check for needless usb_free_urb() checks + if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { + my $expr = $1; + if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) { + WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev); + } + } # warn about #ifdefs in C files # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { |