diff options
author | Miguel Ojeda <ojeda@kernel.org> | 2024-04-01 23:23:01 +0200 |
---|---|---|
committer | Miguel Ojeda <ojeda@kernel.org> | 2024-05-05 19:22:25 +0200 |
commit | 7c81aa85eee536f36ad79339bbbc7528a49d30fe (patch) | |
tree | eaeba2199283f7d4c84f96a20275932ae499c5f3 /rust | |
parent | ae58351a8a44fc017fed085246a08ce4ecf1acd6 (diff) | |
download | lwn-7c81aa85eee536f36ad79339bbbc7528a49d30fe.tar.gz lwn-7c81aa85eee536f36ad79339bbbc7528a49d30fe.zip |
rust: sync: implement `Default` for `LockClassKey`
In the upcoming Rust 1.78.0, Clippy suggests to implement `Default` even
when `new()` is `const`, since `Default::default()` may call `const`
functions even if it is not `const` itself [1]:
error: you should consider adding a `Default` implementation for `LockClassKey`
--> rust/kernel/sync.rs:31:5
|
31 | / pub const fn new() -> Self {
32 | | Self(Opaque::uninit())
33 | | }
| |_____^
Thus implement it.
Link: https://github.com/rust-lang/rust-clippy/pull/10903 [1]
Reviewed-by: Benno Lossin <benno.lossin@proton.me>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20240401212303.537355-2-ojeda@kernel.org
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Diffstat (limited to 'rust')
-rw-r--r-- | rust/kernel/sync.rs | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/rust/kernel/sync.rs b/rust/kernel/sync.rs index c983f63fd56e..0ab20975a3b5 100644 --- a/rust/kernel/sync.rs +++ b/rust/kernel/sync.rs @@ -37,6 +37,12 @@ impl LockClassKey { } } +impl Default for LockClassKey { + fn default() -> Self { + Self::new() + } +} + /// Defines a new static lock class and returns a pointer to it. #[doc(hidden)] #[macro_export] |