diff options
author | Tonghao Zhang <xiangxia.m.yue@gmail.com> | 2020-03-26 04:27:24 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-04-02 17:48:12 -0700 |
commit | 64948427a63f49dd0ce403388d232f22cc1971a8 (patch) | |
tree | cf65449b07bddf5df49abf0f03648de830d75ad0 /net | |
parent | c427bfec18f2190b8f4718785ee8ed2db4f84ee6 (diff) | |
download | lwn-64948427a63f49dd0ce403388d232f22cc1971a8.tar.gz lwn-64948427a63f49dd0ce403388d232f22cc1971a8.zip |
net: openvswitch: use hlist_for_each_entry_rcu instead of hlist_for_each_entry
The struct sw_flow is protected by RCU, when traversing them,
use hlist_for_each_entry_rcu.
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Tested-by: Greg Rose <gvrose8192@gmail.com>
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
-rw-r--r-- | net/openvswitch/flow_table.c | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/net/openvswitch/flow_table.c b/net/openvswitch/flow_table.c index fd8a01ca7a2d..2398d7238300 100644 --- a/net/openvswitch/flow_table.c +++ b/net/openvswitch/flow_table.c @@ -462,12 +462,14 @@ static void flow_table_copy_flows(struct table_instance *old, struct hlist_head *head = &old->buckets[i]; if (ufid) - hlist_for_each_entry(flow, head, - ufid_table.node[old_ver]) + hlist_for_each_entry_rcu(flow, head, + ufid_table.node[old_ver], + lockdep_ovsl_is_held()) ufid_table_instance_insert(new, flow); else - hlist_for_each_entry(flow, head, - flow_table.node[old_ver]) + hlist_for_each_entry_rcu(flow, head, + flow_table.node[old_ver], + lockdep_ovsl_is_held()) table_instance_insert(new, flow); } |