diff options
| author | David Ahern <dsahern@gmail.com> | 2019-01-02 18:57:09 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-02 20:16:37 -0800 |
| commit | c5ee066333ebc322a24a00a743ed941a0c68617e (patch) | |
| tree | 3db3ed11cb1e519581ae51b1b3546afaa7aaa6ba /net | |
| parent | 73155879b3c1ac3ace35208a54a3a160ec520bef (diff) | |
| download | lwn-c5ee066333ebc322a24a00a743ed941a0c68617e.tar.gz lwn-c5ee066333ebc322a24a00a743ed941a0c68617e.zip | |
ipv6: Consider sk_bound_dev_if when binding a socket to an address
IPv6 does not consider if the socket is bound to a device when binding
to an address. The result is that a socket can be bound to eth0 and then
bound to the address of eth1. If the device is a VRF, the result is that
a socket can only be bound to an address in the default VRF.
Resolve by considering the device if sk_bound_dev_if is set.
This problem exists from the beginning of git history.
Signed-off-by: David Ahern <dsahern@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv6/af_inet6.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c index f0cd291034f0..0bfb6cc0a30a 100644 --- a/net/ipv6/af_inet6.c +++ b/net/ipv6/af_inet6.c @@ -350,6 +350,9 @@ static int __inet6_bind(struct sock *sk, struct sockaddr *uaddr, int addr_len, err = -EINVAL; goto out_unlock; } + } + + if (sk->sk_bound_dev_if) { dev = dev_get_by_index_rcu(net, sk->sk_bound_dev_if); if (!dev) { err = -ENODEV; |