diff options
| author | Eric Dumazet <edumazet@google.com> | 2022-10-11 14:27:28 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-10-12 09:10:02 +0100 |
| commit | 87445f369cca2965620e79f87145d3d7fa35befd (patch) | |
| tree | 088b5f8431814ad237703ccd1fdc693892dc0d1e /net | |
| parent | 7e777b1b012e977cfd04347fb347f3f5d097f99e (diff) | |
| download | lwn-87445f369cca2965620e79f87145d3d7fa35befd.tar.gz lwn-87445f369cca2965620e79f87145d3d7fa35befd.zip | |
ipv6: ping: fix wrong checksum for large frames
For a given ping datagram, ping_getfrag() is called once
per skb fragment.
A large datagram requiring more than one page fragment
is currently getting the checksum of the last fragment,
instead of the cumulative one.
After this patch, "ping -s 35000 ::1" is working correctly.
Fixes: 6d0bfe226116 ("net: ipv6: Add IPv6 support to the ping socket.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Lorenzo Colitti <lorenzo@google.com>
Cc: Maciej Żenczykowski <maze@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/ping.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/ping.c b/net/ipv4/ping.c index 517042caf6dc..705672f319e1 100644 --- a/net/ipv4/ping.c +++ b/net/ipv4/ping.c @@ -639,7 +639,7 @@ int ping_getfrag(void *from, char *to, * wcheck, it will be finalized in ping_v4_push_pending_frames. */ if (pfh->family == AF_INET6) { - skb->csum = pfh->wcheck; + skb->csum = csum_block_add(skb->csum, pfh->wcheck, odd); skb->ip_summed = CHECKSUM_NONE; pfh->wcheck = 0; } |