diff options
| author | Pavel Emelyanov <xemul@openvz.org> | 2008-05-04 17:57:29 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-05-04 17:57:29 -0700 |
| commit | c37aa90b0458d87342e0bb083f6bf7d113220d09 (patch) | |
| tree | 1df16515edbc53dc2d3515f95846169d9326b9d7 /net | |
| parent | be0c007ac64f880a946995d6d1fc654acc81484d (diff) | |
| download | lwn-c37aa90b0458d87342e0bb083f6bf7d113220d09.tar.gz lwn-c37aa90b0458d87342e0bb083f6bf7d113220d09.zip | |
bridge: Net device leak in br_add_bridge().
In case the register_netdevice() call fails the device is leaked,
since the out: label is just rtnl_unlock()+return.
Free the device.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/bridge/br_if.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 77a981a1ee52..bff0f5bb12be 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -280,8 +280,10 @@ int br_add_bridge(const char *name) } ret = register_netdevice(dev); - if (ret) + if (ret) { + free_netdev(dev); goto out; + } ret = br_sysfs_addbr(dev); if (ret) |