diff options
| author | Sven Eckelmann <sven.eckelmann@open-mesh.com> | 2016-09-29 17:22:58 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-11-18 10:51:52 +0100 |
| commit | 6de98e87effb2078f2bd5bc5b354dc50808b85b5 (patch) | |
| tree | bdd019b5190ec29c51059a044d1e37ce2292864f /net | |
| parent | a3f000ce7b4447a33569ea3cddc6b29cf90f740a (diff) | |
| download | lwn-6de98e87effb2078f2bd5bc5b354dc50808b85b5.tar.gz lwn-6de98e87effb2078f2bd5bc5b354dc50808b85b5.zip | |
batman-adv: Modify neigh_list only with rcu-list functions
commit 9ca488dd53088d4fcc97258aeeccf21f63b7da1e upstream.
The batadv_hard_iface::neigh_list is accessed via rcu based primitives.
Thus all operations done on it have to fulfill the requirements by RCU. So
using non-RCU mechanisms like hlist_add_head is not allowed because it
misses the barriers required to protect concurrent readers when accessing
the data behind the pointer.
Fixes: cef63419f7db ("batman-adv: add list of unique single hop neighbors per hard-interface")
Signed-off-by: Sven Eckelmann <sven.eckelmann@open-mesh.com>
Acked-by: Linus Lüssing <linus.luessing@c0d3.blue>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/batman-adv/originator.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/originator.c b/net/batman-adv/originator.c index 3940b5d24421..3e9667e467c3 100644 --- a/net/batman-adv/originator.c +++ b/net/batman-adv/originator.c @@ -537,7 +537,7 @@ batadv_hardif_neigh_create(struct batadv_hard_iface *hard_iface, if (bat_priv->algo_ops->neigh.hardif_init) bat_priv->algo_ops->neigh.hardif_init(hardif_neigh); - hlist_add_head(&hardif_neigh->list, &hard_iface->neigh_list); + hlist_add_head_rcu(&hardif_neigh->list, &hard_iface->neigh_list); out: spin_unlock_bh(&hard_iface->neigh_list_lock); |