diff options
| author | Pavel Emelyanov <xemul@openvz.org> | 2007-10-15 12:54:15 -0700 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2007-10-15 12:54:15 -0700 |
| commit | 4ae289444b968b4cefd776ada8da519ce10e56fa (patch) | |
| tree | 06aa4ff04bb1acdb64c29fc4b28a5cf91b1d57b8 /net | |
| parent | f1673ca52c04f1b311abe03fd67cd4d650d19435 (diff) | |
| download | lwn-4ae289444b968b4cefd776ada8da519ce10e56fa.tar.gz lwn-4ae289444b968b4cefd776ada8da519ce10e56fa.zip | |
[NEIGH]: Ensure that pneigh_lookup is protected with RTNL
The pnigh_lookup is used to lookup proxy entries and to
create them in case lookup failed.
However, the "creation" code does not perform the re-lookup
after GFP_KERNEL allocation. This is done because the code
is expected to be protected with the RTNL lock, so add the
assertion (mainly to address future questions from new network
developers like me :) ).
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/neighbour.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index c52df858d0be..cd3af59b38a1 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -481,6 +481,8 @@ struct pneigh_entry * pneigh_lookup(struct neigh_table *tbl, const void *pkey, if (!creat) goto out; + ASSERT_RTNL(); + n = kmalloc(sizeof(*n) + key_len, GFP_KERNEL); if (!n) goto out; |