diff options
| author | Jarno Rajahalme <jarno@ovn.org> | 2016-12-19 17:06:33 -0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-12-20 14:07:41 -0500 |
| commit | 87e159c59d9f325d571689d4027115617adb32e6 (patch) | |
| tree | 1e891ba98f0a5b3874f679a651337aec9d49842b /net | |
| parent | 4c0ef2319a6cc3506db2a546b9e6294ec635eb90 (diff) | |
| download | lwn-87e159c59d9f325d571689d4027115617adb32e6.tar.gz lwn-87e159c59d9f325d571689d4027115617adb32e6.zip | |
openvswitch: Add a missing break statement.
Add a break statement to prevent fall-through from
OVS_KEY_ATTR_ETHERNET to OVS_KEY_ATTR_TUNNEL. Without the break
actions setting ethernet addresses fail to validate with log messages
complaining about invalid tunnel attributes.
Fixes: 0a6410fbde ("openvswitch: netlink: support L3 packets")
Signed-off-by: Jarno Rajahalme <jarno@ovn.org>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Acked-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/openvswitch/flow_netlink.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index d19044f2b1f4..c87d359b9b37 100644 --- a/net/openvswitch/flow_netlink.c +++ b/net/openvswitch/flow_netlink.c @@ -2195,6 +2195,7 @@ static int validate_set(const struct nlattr *a, case OVS_KEY_ATTR_ETHERNET: if (mac_proto != MAC_PROTO_ETHERNET) return -EINVAL; + break; case OVS_KEY_ATTR_TUNNEL: if (masked) |