diff options
| author | Veaceslav Falico <vfalico@redhat.com> | 2013-03-12 06:31:32 +0000 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2013-03-27 02:41:05 +0000 |
| commit | 0edce478d1ce9bb9bfca84350e41962a180b401f (patch) | |
| tree | 3a2a000b2f4299e0bc43d5ee0e02fe748eef1662 /net | |
| parent | ec207c103236a1fa33b838e7710c07253b839962 (diff) | |
| download | lwn-0edce478d1ce9bb9bfca84350e41962a180b401f.tar.gz lwn-0edce478d1ce9bb9bfca84350e41962a180b401f.zip | |
bonding: don't call update_speed_duplex() under spinlocks
[ Upstream commit 876254ae2758d50dcb08c7bd00caf6a806571178 ]
bond_update_speed_duplex() might sleep while calling underlying slave's
routines. Move it out of atomic context in bond_enslave() and remove it
from bond_miimon_commit() - it was introduced by commit 546add79, however
when the slave interfaces go up/change state it's their responsibility to
fire NETDEV_UP/NETDEV_CHANGE events so that bonding can properly update
their speed.
I've tested it on all combinations of ifup/ifdown, autoneg/speed/duplex
changes, remote-controlled and local, on (not) MII-based cards. All changes
are visible.
Signed-off-by: Veaceslav Falico <vfalico@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions