diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2011-10-07 05:35:46 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-10-18 23:32:00 -0400 |
| commit | 835acf5da239b91edb9f7ebe36516999e156e6ee (patch) | |
| tree | 619c14b343ef06c4a9e243f030930983b15530ab /net | |
| parent | 1ce5cce895309862d2c35d922816adebe094fe4a (diff) | |
| download | lwn-835acf5da239b91edb9f7ebe36516999e156e6ee.tar.gz lwn-835acf5da239b91edb9f7ebe36516999e156e6ee.zip | |
l2tp: fix a potential skb leak in l2tp_xmit_skb()
l2tp_xmit_skb() can leak one skb if skb_cow_head() returns an error.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/l2tp/l2tp_core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_core.c b/net/l2tp/l2tp_core.c index ad4ac2601a56..34b2ddeacb67 100644 --- a/net/l2tp/l2tp_core.c +++ b/net/l2tp/l2tp_core.c @@ -1045,8 +1045,10 @@ int l2tp_xmit_skb(struct l2tp_session *session, struct sk_buff *skb, int hdr_len headroom = NET_SKB_PAD + sizeof(struct iphdr) + uhlen + hdr_len; old_headroom = skb_headroom(skb); - if (skb_cow_head(skb, headroom)) + if (skb_cow_head(skb, headroom)) { + dev_kfree_skb(skb); goto abort; + } new_headroom = skb_headroom(skb); skb_orphan(skb); |