diff options
| author | Nikolay Aleksandrov <nikolay@cumulusnetworks.com> | 2015-07-13 06:36:19 -0700 |
|---|---|---|
| committer | Sasha Levin <sasha.levin@oracle.com> | 2015-09-28 18:57:00 -0400 |
| commit | dbb5ff1d61f6e0b6f9bb31565c7be72cbcdda60c (patch) | |
| tree | ae01dcdf01bb88bfe3bb4e797db5803d20191773 /net | |
| parent | ce76b83f30237021a33a7bdda8384784fe65fbc2 (diff) | |
| download | lwn-dbb5ff1d61f6e0b6f9bb31565c7be72cbcdda60c.tar.gz lwn-dbb5ff1d61f6e0b6f9bb31565c7be72cbcdda60c.zip | |
bridge: mdb: fix double add notification
[ Upstream commit 5ebc784625ea68a9570d1f70557e7932988cd1b4 ]
Since the mdb add/del code was introduced there have been 2 br_mdb_notify
calls when doing br_mdb_add() resulting in 2 notifications on each add.
Example:
Command: bridge mdb add dev br0 port eth1 grp 239.0.0.1 permanent
Before patch:
root@debian:~# bridge monitor all
[MDB]dev br0 port eth1 grp 239.0.0.1 permanent
[MDB]dev br0 port eth1 grp 239.0.0.1 permanent
After patch:
root@debian:~# bridge monitor all
[MDB]dev br0 port eth1 grp 239.0.0.1 permanent
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Fixes: cfd567543590 ("bridge: add support of adding and deleting mdb entries")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/bridge/br_mdb.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/bridge/br_mdb.c b/net/bridge/br_mdb.c index b07766432d3b..cc641541d38f 100644 --- a/net/bridge/br_mdb.c +++ b/net/bridge/br_mdb.c @@ -347,7 +347,6 @@ static int br_mdb_add_group(struct net_bridge *br, struct net_bridge_port *port, return -ENOMEM; rcu_assign_pointer(*pp, p); - br_mdb_notify(br->dev, port, group, RTM_NEWMDB); return 0; } |