diff options
| author | Sasha Levin <sasha.levin@oracle.com> | 2016-01-07 14:52:43 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-01-28 21:57:11 -0800 |
| commit | 755aa4fb5c148e9d0cf311ed9e1ce642dac69420 (patch) | |
| tree | 4cba6cbd6689a69a57d46a2f9eadebac34db9b73 /net | |
| parent | 003b127e3c9e5bc83249e1106fd3de9da8dcf741 (diff) | |
| download | lwn-755aa4fb5c148e9d0cf311ed9e1ce642dac69420.tar.gz lwn-755aa4fb5c148e9d0cf311ed9e1ce642dac69420.zip | |
net: sctp: prevent writes to cookie_hmac_alg from accessing invalid memory
[ Upstream commit 320f1a4a175e7cd5d3f006f92b4d4d3e2cbb7bb5 ]
proc_dostring() needs an initialized destination string, while the one
provided in proc_sctp_do_hmac_alg() contains stack garbage.
Thus, writing to cookie_hmac_alg would strlen() that garbage and end up
accessing invalid memory.
Fixes: 3c68198e7 ("sctp: Make hmac algorithm selection for cookie generation dynamic")
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/sctp/sysctl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c index dfa532f00d88..48273d94484d 100644 --- a/net/sctp/sysctl.c +++ b/net/sctp/sysctl.c @@ -310,7 +310,7 @@ static int proc_sctp_do_hmac_alg(struct ctl_table *ctl, int write, struct ctl_table tbl; bool changed = false; char *none = "none"; - char tmp[8]; + char tmp[8] = {0}; int ret; memset(&tbl, 0, sizeof(struct ctl_table)); |