diff options
| author | Anton Protopopov <a.s.protopopov@gmail.com> | 2016-02-16 21:43:16 -0500 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-03-02 16:29:14 +0100 |
| commit | 7b715d926d6bcd9ad1ccdf436e659aa86eebdeb5 (patch) | |
| tree | 7e0a7838ba8e286e2550343cbb6715895f8403ff /net | |
| parent | 27b6d267f4d3652dee80ced90800904ed0df6a05 (diff) | |
| download | lwn-7b715d926d6bcd9ad1ccdf436e659aa86eebdeb5.tar.gz lwn-7b715d926d6bcd9ad1ccdf436e659aa86eebdeb5.zip | |
rtnl: RTM_GETNETCONF: fix wrong return value
[ Upstream commit a97eb33ff225f34a8124774b3373fd244f0e83ce ]
An error response from a RTM_GETNETCONF request can return the positive
error value EINVAL in the struct nlmsgerr that can mislead userspace.
Signed-off-by: Anton Protopopov <a.s.protopopov@gmail.com>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'net')
| -rw-r--r-- | net/ipv4/devinet.c | 2 | ||||
| -rw-r--r-- | net/ipv6/addrconf.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index f4b34d8f92fe..68447109000f 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -1785,7 +1785,7 @@ static int inet_netconf_get_devconf(struct sk_buff *in_skb, if (err < 0) goto errout; - err = EINVAL; + err = -EINVAL; if (!tb[NETCONFA_IFINDEX]) goto errout; diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 6c629ffb8756..bbf35875e4ef 100644 --- a/net/ipv6/addrconf.c +++ b/net/ipv6/addrconf.c @@ -528,7 +528,7 @@ static int inet6_netconf_get_devconf(struct sk_buff *in_skb, if (err < 0) goto errout; - err = EINVAL; + err = -EINVAL; if (!tb[NETCONFA_IFINDEX]) goto errout; |