diff options
| author | Rainer Weikusat <rweikusat@mobileactivedefense.com> | 2016-02-11 19:37:27 +0000 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-03-02 16:29:11 +0100 |
| commit | 6126da76d00e981cca46080c464f9c309067b022 (patch) | |
| tree | 61e59982c9e86603d974f680461736f6f60e9ac6 /net | |
| parent | d1c560183199c55cfe50bd176dffdc16e5f55b6b (diff) | |
| download | lwn-6126da76d00e981cca46080c464f9c309067b022.tar.gz lwn-6126da76d00e981cca46080c464f9c309067b022.zip | |
af_unix: Guard against other == sk in unix_dgram_sendmsg
[ Upstream commit a5527dda344fff0514b7989ef7a755729769daa1 ]
The unix_dgram_sendmsg routine use the following test
if (unlikely(unix_peer(other) != sk && unix_recvq_full(other))) {
to determine if sk and other are in an n:1 association (either
established via connect or by using sendto to send messages to an
unrelated socket identified by address). This isn't correct as the
specified address could have been bound to the sending socket itself or
because this socket could have been connected to itself by the time of
the unix_peer_get but disconnected before the unix_state_lock(other). In
both cases, the if-block would be entered despite other == sk which
might either block the sender unintentionally or lead to trying to unlock
the same spin lock twice for a non-blocking send. Add a other != sk
check to guard against this.
Fixes: 7d267278a9ec ("unix: avoid use-after-free in ep_remove_wait_queue")
Reported-By: Philipp Hahn <pmhahn@pmhahn.de>
Signed-off-by: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Tested-by: Philipp Hahn <pmhahn@pmhahn.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'net')
| -rw-r--r-- | net/unix/af_unix.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c index 5fb2d2af3e52..c5536b7d8ce4 100644 --- a/net/unix/af_unix.c +++ b/net/unix/af_unix.c @@ -1700,7 +1700,12 @@ restart_locked: goto out_unlock; } - if (unlikely(unix_peer(other) != sk && unix_recvq_full(other))) { + /* other == sk && unix_peer(other) != sk if + * - unix_peer(sk) == NULL, destination address bound to sk + * - unix_peer(sk) == sk by time of get but disconnected before lock + */ + if (other != sk && + unlikely(unix_peer(other) != sk && unix_recvq_full(other))) { if (timeo) { timeo = unix_wait_for_peer(other, timeo); |